The whole options module should be inline #14417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer explict |
|
The tests have a lot of |
narimiran
pushed a commit
that referenced
this pull request
Jun 1, 2020
* The whole options module should be inline * Use inline per proc and tag `lent` where appropriate * Remove lent annotation (failing at compiletime) (cherry picked from commit f71f8b0)
EchoPouet
pushed a commit
to EchoPouet/Nim
that referenced
this pull request
Jun 13, 2020
…1.2] * The whole options module should be inline * Use inline per proc and tag `lent` where appropriate * Remove lent annotation (failing at compiletime)
|
@mratsim did you try to simply add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noneshows up as a bottleneck in benchmark :/I'm not going to turn this into another blog post like #9514 but this takes 45s to raytrace in C++ and the Nim code is almost equivalent besides choosing to use Option return values.
For example the
nonefunction in the benchmark belowIdeally this is a small enough change to be backported in 1.2.2 because we do use Option in Nimbus.
Furthermore the values are quite huge to wrap/unwrap (256-bit hash) so inline should help significantly.